Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for map_screen.dart #1403

Closed
palisadoes opened this issue Jan 24, 2023 · 9 comments
Closed

Views: Create tests for map_screen.dart #1403

palisadoes opened this issue Jan 24, 2023 · 9 comments
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/after_auth_screens/venue/map_screen.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/after_auth_screens/venue/map_screen_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
  • No functionality must be removed to achieve this goal.
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Jan 24, 2023
@palisadoes palisadoes added good first issue Good for newcomers points 01 and removed bug Something isn't working parent The issue is generating more sub-issues labels Jan 24, 2023
@Adiii1436
Copy link

Hello @palisadoes ! I want to work on this issue . Please assign this issue to me.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 5, 2023
@Adiii1436 Adiii1436 removed their assignment Feb 10, 2023
@literalEval
Copy link
Member

@palisadoes please assign this to me.

@palisadoes
Copy link
Contributor Author

@literalEval are already working on other issues

@Skdahale
Copy link

@palisadoes Can I work on this issue?

@noman2002
Copy link
Member

Sure. Go ahead. @Skdahale

@palisadoes
Copy link
Contributor Author

@Skdahale I'm going to unassign due to inactivity. It's been 2 weeks, we need to give others a chance.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@Manik2708
Copy link

Duplicate of #2146, please close this issue.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 20, 2023
@Cioppolo14
Copy link

Closing as a duplicate.

@Cioppolo14 Cioppolo14 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants