Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: Create tests for event_info_body.dart #1404

Closed
palisadoes opened this issue Jan 24, 2023 · 3 comments · Fixed by #1462
Closed

Views: Create tests for event_info_body.dart #1404

palisadoes opened this issue Jan 24, 2023 · 3 comments · Fixed by #1462
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/after_auth_screens/events/event_info_body.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • These tests must be placed in a single file with the name test/views/after_auth_screens/events/event_info_body_test.dart. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Jan 24, 2023
@palisadoes palisadoes added good first issue Good for newcomers points 01 and removed bug Something isn't working parent The issue is generating more sub-issues labels Jan 24, 2023
@literalEval
Copy link
Member

I would like to work on this issue and make the tests reach 100%. Please assign it to me.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 5, 2023
@literalEval
Copy link
Member

literalEval commented Feb 6, 2023

@noman2002 @CyberWake @TheHazeEffect I need some help regarding testing.

In this particular block, there is conditional rendering based on whether the view model is busy or not. How to test this functionality ? I mean how to set the view model to be busy and idle on wish ?

image

Can I add some test functions on that ViewModel to achieve this ?

@literalEval
Copy link
Member

I figured it out. The setState method is already exposed to the viewModel. Leaving the comments as it is so that maybe someone can find in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants