-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models: Tests for chat_message.dart #1425
Comments
@palisadoes can I work on this? |
Please coordinate with the contributors referenced in the issue. |
@noman2002 it seems that ChatUser is not fully serializable. when I call I do have the chat_user.g.dart and chat_message.g.dart files, but still it is not serializing properly. any suggestion? |
@palisadoes Your thought? |
@noman2002 I do not have experience with object serialization yet, but allow me sometime to learn about it. |
I just took a look at https://docs.flutter.dev/development/data-and-backend/json and found a possible solution. |
@antonio-pedro99 I don't think there is any issue with serialisation. It shows like that because we are using models for that and that is being printed over there as Instance of 'chatuser'. |
Sure go ahead. |
@noman2002 fixed! `@JsonSerializable(explicitToJson: true) factory ChatMessage.fromJson(Map<String, dynamic> json) => String? id; |
Great. Have you written the test for it? If yes, check the code coverage, if it is 100%, Please create a PR for it. |
@noman2002 how can I check the coverage? |
I want to contribute to this repository and want to get involved in GSoC discussions. |
You can join the slack channel @shivanshu814 |
Please check the CONTRIBUTING.md file in the repository's root directory. If the instructions are not sufficient then let me know |
We will need unittests done for all methods, classes and functions found in this file.
Any widgets referenced in this file must also have unittests done
PR Acceptance Criteria
The text was updated successfully, but these errors were encountered: