Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update method of User class updates wrongly. #1438

Closed
literalEval opened this issue Jan 28, 2023 · 4 comments
Closed

Update method of User class updates wrongly. #1438

literalEval opened this issue Jan 28, 2023 · 4 comments
Assignees
@literalEval
Labels
bug Something isn't working

Comments

@literalEval
Copy link
Member

Describe the bug
update method of User class has abnormality (due to copy paste I guess). Currently it updates firstName, lastName, email and image to firstName

Expected behavior
Attributes should update correctly.

Actual behavior
4 attributes are updating to a single value.

Screenshots
image

@palisadoes please assign this to me.
@literalEval literalEval added the bug Something isn't working label Jan 28, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Jan 28, 2023
@palisadoes
Copy link
Contributor

This means the tests for the class are incomplete. Please ensure that the tests for the file in which this class is listed has 100% code coverage as part of the PR to resolve this issue

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Jan 28, 2023
@literalEval
Copy link
Member Author

literalEval commented Jan 28, 2023 •
edited

Actually I was working on its test and found out this issue. Will resolve both of them.

@literalEval literalEval mentioned this issue Jan 28, 2023
Closed
@palisadoes
Copy link
Contributor

I'm going to close both the PR and the issue. The aim of doing tests is to fix bugs that are found as part of the process. Creating a bug for every testing error found creates more work for our team of volunteers. Please respect their time.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2023
@literalEval
Copy link
Member Author

Understood. From next time I will add the code modifications in the test itself. Sorry for inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@literalEval literalEval

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix update method of User class literalEval/talawa
2 participants
@palisadoes @literalEval