Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flutter version in the workflow #1500

Closed
literalEval opened this issue Feb 15, 2023 · 8 comments · Fixed by #1510
Closed

Upgrade flutter version in the workflow #1500

literalEval opened this issue Feb 15, 2023 · 8 comments · Fixed by #1510
Labels
feature request unapproved Unapproved, needs to be triaged

Comments

@literalEval
Copy link
Member

literalEval commented Feb 15, 2023

Is your feature request related to a problem? Please describe.

Flutter version used in our workflow is almost 1 years old now. We are using flutter: 3.0.0, whereas the latest is flutter: 3.7.3 on the stable channel. This will soon lead to dependency issues and upgrading packages won't work.

Describe the solution you'd like

I would like to bump the flutter version in our workflow and upgrade/fix any dependency issue/deprecation which comes due to this bump.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Feb 15, 2023
@palisadoes
Copy link
Contributor

You will also need to upgrade flutter in the code base. Is that included in your plan?

@literalEval
Copy link
Member Author

literalEval commented Feb 15, 2023

Yes. I have done it locally. Gives 2 errors (these are from specific plugins though) and 800 lint warnings/deprecations :)
Will fix all of them

@literalEval
Copy link
Member Author

@palisadoes any updates on this ?

@palisadoes
Copy link
Contributor

If you have done the upgrade to the latest flutter to be compatible with the work flow, then submit the PR. Make sure the test coverage level is maintained.

@literalEval
Copy link
Member Author

literalEval commented Feb 17, 2023

Sure. I will open a PR till tomorrow. Can you please stop merging new PRs till then ? Because it will cause massive merge conflicts.

@palisadoes
Copy link
Contributor

OK

@literalEval
Copy link
Member Author

@palisadoes some <10 tests are failing. How about I comment them out and push. And after the merge, I will make them work in new PRs or maybe some newcomer can tackle them ?
Because making all the tests to work may take some time which will unnecessarily halt others' work. If you like this idea, then I will open the respective PR tomorrow. Otherwise I will try to fix them.

Thanks and good night.

@palisadoes
Copy link
Contributor

OK. Please provide the full paths to the files that the failing tests are testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request unapproved Unapproved, needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants