Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The profile page screen looks weird, irregular and overflowed #1608

Closed
Kushalrock opened this issue Mar 4, 2023 · 9 comments · Fixed by #1609
Closed

The profile page screen looks weird, irregular and overflowed #1608

Kushalrock opened this issue Mar 4, 2023 · 9 comments · Fixed by #1609
Assignees
Labels
bug Something isn't working

Comments

@Kushalrock
Copy link

Kushalrock commented Mar 4, 2023

Describe the bug
The profile page looks weird and irregular and also overflows on certain older screens like Google Pixel 2.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app
  2. Go to the profile page

Expected behavior
It should have been regular and no overflow should have happened

Actual behavior
Irregular and overflow. By irregular I mean the spacing between different menu bar tiles (specifically my bar and donate us) and overflowing of pixels. Please see the attached image.

Screenshots
image

Additional details
Model Of Phone - Google pixel 2

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@Kushalrock Kushalrock added the bug Something isn't working label Mar 4, 2023
@Kushalrock
Copy link
Author

Is it okay if I take up this issue?

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 4, 2023
@palisadoes
Copy link
Contributor

Please explain what weird and irregular means

@Kushalrock
Copy link
Author

@palisadoes I have attached an image you can see my task and donate us don't have much space in between them also overflowing by pixels.

@palisadoes
Copy link
Contributor

Please state that in the issue description so that other people will know exactly what you are mentioning. We use the issue template to make it easier for us to do searches for past problems. When they are not sufficiently descriptive this is harder.

@Kushalrock
Copy link
Author

Please state that in the issue description so that other people will know exactly what you are mentioning. We use the issue template to make it easier for us to do searches for past problems. When they are not sufficiently descriptive this is harder.

I have updated the issue description. Sorry about that. Please let me know if you assign me this task. I would be more than happy to contribute to this.

@palisadoes
Copy link
Contributor

https://youtu.be/ix3eSReJj2k?t=1256 There is more to this. The icon colors are not consistent and may be hard coded versus using a variable that passenger can recognize.

This is shown in the video link. Please update that too in your fix.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 4, 2023
@Kushalrock
Copy link
Author

Kushalrock commented Mar 4, 2023

What about the donate us button? Should it be the same color or should reflect the theme?? @palisadoes

image

@palisadoes
Copy link
Contributor

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants