Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for signup_details_view_model.dart #1740

Closed
literalEval opened this issue Apr 2, 2023 · 7 comments
Closed

Fix test for signup_details_view_model.dart #1740

literalEval opened this issue Apr 2, 2023 · 7 comments
Labels
no-issue-activity No issue activity test Testing application

Comments

@literalEval
Copy link
Member

literalEval commented Apr 2, 2023

Recently we enforced explicit return type declaration for functions, which led to the discovery of many poorly written tests. Many of those were fixed at the same time, but some will take some extra consideration. One of them being the test/view_model_tests/signup_details_view_model_test.dart file.

When you signUp, the test is supposed to test all of the TextControllers, InputFields and GraphQL queries to dictate whether they are working fine or not. But the earlier test simply leveraged the dynamic return type to return String and assert 100% coverage.

image

Solution
Test the failing test shown in the above image properly.

@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels Apr 2, 2023
@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Apr 3, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 14, 2023
@palisadoes
Copy link
Contributor

Unassigning due to inactivity and no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@literalEval
Copy link
Member Author

@palisadoes oh sorry. I didn't notice that you assigned this to me :)
Let someone else do this one. I already have quite some issues to work on :)

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 15, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 26, 2023
@github-actions
Copy link

This issue did not get any activity in the past 180 days and thus has been closed. Please check if the newest release or develop branch has it fixed. Please, create a new issue if the issue is not fixed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
@palisadoes palisadoes reopened this Oct 24, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Oct 25, 2023
Copy link

github-actions bot commented Nov 5, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 5, 2023
@Dante291
Copy link

Dante291 commented Nov 7, 2023

@Ayush0Chaudhary Sir there is already a valid modified test written for this file so close this issue. test/view_model_tests/pre_auth_view_models/signup_details_view_model_test.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity No issue activity test Testing application
Projects
None yet
Development

No branches or pull requests

4 participants