-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for signup_details_view_model.dart
#1740
Comments
This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning due to inactivity and no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue. |
@palisadoes oh sorry. I didn't notice that you assigned this to me :) |
This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
This issue did not get any activity in the past 180 days and thus has been closed. Please check if the newest release or develop branch has it fixed. Please, create a new issue if the issue is not fixed. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@Ayush0Chaudhary Sir there is already a valid modified test written for this file so close this issue. test/view_model_tests/pre_auth_view_models/signup_details_view_model_test.dart |
Recently we enforced
explicit return type declaration
for functions, which led to the discovery of many poorly written tests. Many of those were fixed at the same time, but some will take some extra consideration. One of them being the test/view_model_tests/signup_details_view_model_test.dart file.When you
signUp
, the test is supposed to test all of theTextControllers
,InputFields
andGraphQL queries
to dictate whether they are working fine or not. But the earlier test simply leveraged the dynamic return type to returnString
and assert 100% coverage.Solution
Test the failing test shown in the above image properly.
The text was updated successfully, but these errors were encountered: