Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Adding back the plugin architecture logic for talawa app #1758

Closed
SiddheshKukade opened this issue Apr 9, 2023 · 10 comments
Closed
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity

Comments

@SiddheshKukade
Copy link
Member

Describe the bug
Recently, due to a code commenting error, some part of the code has been deleted from talawa, talawa-admin and talawa-api.
The reason for this being contributors didn't read the docs on Plugins before deleting those files and comments from the code. That code needs to be re-added and made supportive of the current major changes in the project to make it work again.

To Reproduce
Steps to reproduce the behaviour:

  1. Try installing plugins on talawa-admin
  2. See changes in the app
  3. nothing happens

Expected behaviour
Plugins should work fine means app features should be controlled by talawa-admin

Actual behaviour
Nothing happens after uninstalling or installing plugins on the app.

Screenshots
N/A

Additional details
N/A

@SiddheshKukade SiddheshKukade added the bug Something isn't working label Apr 9, 2023
@SiddheshKukade
Copy link
Member Author

@palisadoes Sir, please assign

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 9, 2023
@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Apr 9, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 20, 2023
@SiddheshKukade
Copy link
Member Author

Hello, @palisadoes sir I've now manged to get plugins working again.

Here's the demo:
https://user-images.githubusercontent.com/65951872/235835450-7a248f03-f235-4a8c-852d-49d6d3428b41.mp4

I'll create a PR with some final changes in a few hours as I have to attend some classes today.

@palisadoes
Copy link
Contributor

Based on the video we should consider modifying the plugin detection mechanism at a later date.

  1. Check for plugins on startup and display the icons for those that are enabled.
  2. If someone clicks on the icon for a plugin that has been removed since startup, it should be removed and an error shown.

More discussion on this will be necessary. The approach I have suggested may not be suitable.

@github-actions github-actions bot removed the no-issue-activity No issue activity label May 4, 2023
@SiddheshKukade
Copy link
Member Author

@palisadoes, Thanks
The approach looks good to me.

  1. Check for plugins on startup and display the icons for those that are enabled.

I will get started implement this in #1778

  1. If someone clicks on the icon for a plugin that has been removed since startup, it should be removed and an error shown.

For this, I need to create a GraphQL query to get the the installation status for that specific plugin from db. Then we can use that to check for the status of that specific plugin.
I would also need to discuss some approaches to implement this with mentors and admins as the plugins in navbar are getting handled differently as compare to the normal UI plugins.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 17, 2023
@SiddheshKukade SiddheshKukade added area/performance and removed no-issue-activity No issue activity labels Jun 11, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jun 22, 2023
@palisadoes
Copy link
Contributor

What's the status on this?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 9, 2023
@palisadoes
Copy link
Contributor

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants