-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Register for event doesn't work #188
Comments
Hey @yasharth291 are you working on it? If not @Sagar2366 can you assign me this. Also, adding an event is also not working at least on my end. So should I create a new issue for the same? |
@pr4nshul you can start working on this issue. |
Ok, got it |
I was thinking we should also add a button to unregister in the drop down. |
@Sagar2366 Close this issue as you mentioned it is solved in previous master changes. |
@pr4nshul be clear when you say small UI improvement. If you are talking about registering for the event it is already done and don't need any UI change. But if you are referring to unregister option then please continue discussion on slack. We welcome new ideas from students and hear everyone's opinions. At the same time we expect everyone to follow the guidelines - discuss idea first in slack channels and based on discussion create new issue. Avoid suggesting new ideas/new issue discussions here in another issue. As explained you earlier if makes difficult to keep track of ongoing issue. |
Ok so what i mean bt small UI improvement is , when the user clicks the register button the screen doesn't refresh instantly and it displays you are not registered until you refresh . I will send a video for the same in few minutes. And with the changes that I made that on the PR the page get reloaded as soon as the user registers for the event. Hence , user doesn't need to refresh manually to see whether he was able to register for the event or not. I was not talking about the unregister button. I won't suggest new ideas under any issue anymore as you told me before. Next time I will be as descriptive as I can be , sorry for the ambiguity caused. |
20210326_113240.mp4This is on current master |
20210325_161213.mp4This is after the changes I have in PR #509 |
Hey @Sagar2366 , did you look at this? If you think this change is redundant then I would close this issue. |
Is it solved @pr4nshul @Sagar2366 sir |
The button is working as intended, we just need proper state management to update the user that they are registered . So, you can close the issue, I guess. |
@Sagar2366 sir can you please close it |
when clicked on register for event the screen only loads. And stucks at a place.
The text was updated successfully, but these errors were encountered: