Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade video_player from 2.6.1 to 2.7.0 #1956

Closed
palisadoes opened this issue Jul 12, 2023 · 10 comments
Closed

Upgrade video_player from 2.6.1 to 2.7.0 #1956

palisadoes opened this issue Jul 12, 2023 · 10 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix

Comments

@palisadoes
Copy link
Contributor

Bumps video_player from 2.6.1 to 2.7.0.

Commits
  • 5d6e48c [video_player] Add a Uri-typed factory method (#3513)
  • 6e1918f [all] Update UIViewControllerBasedStatusBarAppearance to true (#4225)
  • e13b8c4 [tool] Only run unit tests in Chrome for inline web (#4153)
  • da72219 remove unnecessary typed_data imports (#4136)
  • 81e3428 [ci] Removes bespoke web scripts. (#4129)
  • 6b326e8 [video_player]: Bump exoplayer_version from 2.18.6 to 2.18.7 in /packages/vid...
  • 9f74144 [many] Bump most robolectric dependencies to version 4.10.3 (#4128)
  • 5c69914 [video_player]: Bump exoplayer_version from 2.18.5 to 2.18.6 in /packages/vid...
  • 7319ca8 [various] Update minimum Flutter version to 3.3 (#3967)
  • 2323aa4 [video_player] foundation - reduce seek accuracy to fix seek to end bug (#3784)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

You will need to also fix this deprecated code:

   info • 'VideoPlayerController.VideoPlayerController.network' is deprecated and shouldn't be used. Use VideoPlayerController.networkUrl instead • lib/widgets/video_widget.dart:29:19 • deprecated_member_use

Refer to this dependabot PR for details:

@palisadoes palisadoes added the bug Something isn't working label Jul 12, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file security Security fix unapproved Unapproved, needs to be triaged labels Jul 12, 2023
@andoriyaprashant
Copy link

Hey @palisadoes Please assign me this issue
Thank you

@andoriyaprashant
Copy link

Hey @palisadoes
Please review my pull request #1957
Thank you

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 23, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivitey

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jul 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@jay11125
Copy link

jay11125 commented Aug 22, 2023

Hey @palisadoes,
I've created the PR #1999 for this issue. I have solved the issue by updating the deprecated code with the one mentioned in the release notes of video_player.
Please note that this PR also contains intl package upgrade to 0.18.1 as it was required to run the project locally.
Thank you.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 23, 2023
@palisadoes
Copy link
Contributor Author

You need to request to be assigned the issue before submitting a PR. Please read the CONTRIBUTING.md file. I'll pass this time. The next time the PR will be closed.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Sep 4, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to no activity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Sep 21, 2023
@literalEval
Copy link
Member

Please close as already updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix
Projects
None yet
4 participants