-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Talawa connection URL string to the hamburger menu. Make the Talawa demo work without URL string. #2137
Comments
@aashimawadhwa could you please assign this issue to me. |
Please check if i am in right track, correct me if i am wrong.
Clarifications:
|
@Azad99-9 You've got it mostly correct. The step 1b is not needed at the moment. The app should just take the user to an unpopulated home page once loaded. In other words, there should be no authorisation when starting up the app, it should just take the user to a version of Talawa that has not pulled in any data from the API. Clarifications:
|
follow up: Rightnow the organization url we are specifying at login time does not belong to any specific org but its the url of the api itself. |
@palisadoes please have a look at above comment. |
@Azad99-9 Please refer to this document: https://docs.talawa.io/docs/introduction/core-concepts#community Each API instance handles a community or So the URL is really a Start with the assumption that the Mobile App can store only one URL at a time. When we know that works as part of completing this issue we can focus on the Mobile App storing multiple We'll need to change the terminology in the App to |
@palisadoes the above information was really helpful and understood.👍 |
@palisadoes , @DMills27 i have implemented the feature and made multiple UI changes in the app that were demanded by the feature. Now how can I share you the apk so that you can review the changes and give me feedback for any modifications. |
@Ayush0Chaudhary This should interest you. |
@Ayush0Chaudhary , @palisadoes , @DMills27 please have a look at the demo video and let me know if any modifications. flow_demo.mp4 |
when the customalertdialog appears saying that "please login to make a post" if the user clicks on login he will be navigated to the seturl screen and the login/signup flow takes over from there and the same applies to all the remaining user specific actions like donation, adding event etc. Prompting the user to login/signup to use the app in a full pledged mode. |
@palisadoes i am glad that you have suggested some changes. One straight forward way would be showing a thin banner on top of navigation bar in every page, mentioning the prompt messages like
by clicking on this banner user can directly go to community url page. I would like to know your thoughts on this approach. |
|
I agree with Peter's suggestions. Additionally, I think you need to make it clear that there's a distinction between logging in and joining an organisation. The video you posted suggests that they are somewhat synonymous in the initial steps when this is not the case. It would be better to prompt the user for an organisation url string then segue to the login screen to make this clear. That is, instead of the 'login' in the hamburger menu it should be 'join a new organisation'; the login option should not appear in the hamburger menu at all. After the user has joined an organisation by inputting an organisation url string they should be prompted to login in the stage after that and subsequently after that they should only have the option to sign up for other organisations they wish to join if they have the requisite connection string. This would make the transitions more logical. |
yeah noted. |
Previously I chose to place the "Login" option in the hamburger menu instead of the "Community URL" is because of the reason users might not immediately grasp the organization's structure within our app. Initially, they are more likely to search for a login or signup option. However, I've reconsidered, and I will now replace the "Login/Signup" section with the "Community URL" option.
yeah this is already implemented and will be left as it is.
@DMills27 for this part, Currently, we lack unique connection strings for each organization. Therefore, following the suggestion from @palisadoes, our focus will be on entering a sole parent community URL that links to a singular API instance to address this matter for now. At this stage, we'll enable users to switch between the organizations existing within the parent community. |
@palisadoes i will trigger the left drawer(hamburger menu) whenever a user specific action is performed. |
better approach would be prompting the user to enter a community url by focusing on the join organization button from hamburger menu. Letting the user decide to continue the demo mode or join a community. The UI would look similar to the above image. @palisadoes , @DMills27 what are your thoughts? |
@Azad99-9 What you're describing is called a 'feature tour' and it's the right idea. Ideally you want some functionality within the app to guide the user to what options are available within it. Rather than prompting the user to enter a community you should have different silhouettes centred about the buttons/menus the user can use to guide them as to how they can add their organisations. Note you should have the option for the user to opt out of the feature tour if they want. |
@palisadoes , @DMills27 In the demo video I shared, I utilized the approach conditional UI rendering based on the user.loggedIn attribute for displaying demo-specific widgets. While this approach worked, as the code expanded, it started to become cumbersome. So I am considering to define new Demo routes to render these Demo widgets which would be a more elegant solution. This way we can conditionally navigate to the desired-mode and keep them seperate. I welcome any better solutions to handle this scenario, from you side. |
@Azad99-9 The demo routes idea seems fine. Can you come up with a basic implementation and the post the video recording here? Nothing too fancy we just need to see if you got the gist of what needs to be implemented. |
@DMills27 Moreover, considering our recent segmentation of the app into |
@palisadoes , @DMills27 please have a look at the demo video and let me know if any modifications. select-organization-feature_oR4cEGJY.mp4 |
@Azad99-9 For the most part it looks good! I only have some very minor nitpicks such as the speed as to which the various components are being zoomed into. Good job! |
thanks @DMills27 . |
is it ok additionally should i enhance any part of it apart from the speed as you have mentioned. |
@Azad99-9 Please create a PR for this and ask @DMills27 and @Ayush0Chaudhary to review it. Include a link to your most recent video. The final details can be discussed there. |
Sure @palisadoes , I have some tests left for the code i changed after writing them I will raise the PR. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Is your feature request related to a problem? Please describe.
Having to enter a connection URL string in order to use Talawa is counterproductive; it requires one to setup the API or have it available somewhere to see the frontend's features and functionalities. We would much rather have the user be able to enter the app to get a look and free for it without having the API available.
Describe the solution you'd like
Have the user access the Talawa frontend and then give them an option to connect to an organisation via the hamburger menu, more specifically through the
Join new organization
option. The logic should allow the user to enter a connection string if they are not already connected to any org, as well as, allow them to sift through the different orgs they connected to on a separate page.The text was updated successfully, but these errors were encountered: