-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write tests for service navigation_service.dart #2158
Comments
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@palisadoes @noman2002 |
@Manik2708 Assigned to you, please consider adding a profile picture. It helps us to remember people who are consistently working. |
PR #2230 raised, please see for the review! |
This issue has to be reopened. The PR is causing our workflows to fail. |
Can you tell me reason of failing of Workflows? |
After carefully watching the order of PRs, PR #2231 was raised just after #2230 but was merged before the PR #2230 and PR #2231 modifies the same change in |
PR #2240 raised, Kindly see for review! |
@Manik2708 PRs are not merged in the order. Any PR which got the approval can be merged |
Sure, thanks. |
Not complaining, was just laughing at the situation, how the same file was edited by two PRs at the same time :) |
Please be more objective in your tone. And this is no where written that same file cannot be edited at once. Both the issues are completely different. One deals with test coverage while the other fixes a bug. |
oh lol might've been my bad, the bug fix was required for my pr to work ill communicate better next time :D |
No worries! Thanks for your concern. |
The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage.
We will need unittests done for all methods, classes and functions found in this file.
Any widgets referenced in this file must also have unittests done
The current code coverage for this file can be found here:
The text was updated successfully, but these errors were encountered: