Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for service navigation_service.dart #2158

Closed
palisadoes opened this issue Nov 26, 2023 · 14 comments · Fixed by #2230 or #2240
Closed

Write tests for service navigation_service.dart #2158

palisadoes opened this issue Nov 26, 2023 · 14 comments · Fixed by #2230 or #2240
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage.

We will need unittests done for all methods, classes and functions found in this file.

Any widgets referenced in this file must also have unittests done

lib/services/navigation_service.dart

The current code coverage for this file can be found here:

@palisadoes palisadoes added the bug Something isn't working label Nov 26, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Nov 26, 2023
@palisadoes palisadoes added good first issue Good for newcomers test Testing application and removed bug Something isn't working labels Nov 26, 2023
Copy link

github-actions bot commented Dec 7, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 7, 2023
@Manik2708
Copy link

@palisadoes @noman2002
Can you assign this issue to me

@noman2002 noman2002 removed unapproved Unapproved, needs to be triaged no-issue-activity No issue activity labels Dec 8, 2023
@noman2002
Copy link
Member

@Manik2708 Assigned to you, please consider adding a profile picture. It helps us to remember people who are consistently working.

@Manik2708
Copy link

PR #2230 raised, please see for the review!

@palisadoes
Copy link
Contributor Author

This issue has to be reopened. The PR is causing our workflows to fail.

@palisadoes palisadoes reopened this Dec 10, 2023
@Manik2708
Copy link

This issue has to be reopened. The PR is causing our workflows to fail.

Can you tell me reason of failing of Workflows?

@Manik2708
Copy link

This issue has to be reopened. The PR is causing our workflows to fail.

Can you tell me reason of failing of Workflows?

After carefully watching the order of PRs, PR #2231 was raised just after #2230 but was merged before the PR #2230 and PR #2231 modifies the same change in navigation_service.dart which leads to Errors. Will be raising a new PR shortly!

@Manik2708
Copy link

PR #2240 raised, Kindly see for review!

@noman2002
Copy link
Member

This issue has to be reopened. The PR is causing our workflows to fail.

Can you tell me reason of failing of Workflows?

After carefully watching the order of PRs, PR #2231 was raised just after #2230 but was merged before the PR #2230 and PR #2231 modifies the same change in navigation_service.dart which leads to Errors. Will be raising a new PR shortly!

@Manik2708 PRs are not merged in the order. Any PR which got the approval can be merged

@noman2002
Copy link
Member

PR #2240 raised, Kindly see for review!

Sure, thanks.

@Manik2708
Copy link

This issue has to be reopened. The PR is causing our workflows to fail.

Can you tell me reason of failing of Workflows?

After carefully watching the order of PRs, PR #2231 was raised just after #2230 but was merged before the PR #2230 and PR #2231 modifies the same change in navigation_service.dart which leads to Errors. Will be raising a new PR shortly!

@Manik2708 PRs are not merged in the order. Any PR which got the approval can be merged

Not complaining, was just laughing at the situation, how the same file was edited by two PRs at the same time :)

@noman2002
Copy link
Member

Please be more objective in your tone. And this is no where written that same file cannot be edited at once. Both the issues are completely different. One deals with test coverage while the other fixes a bug.

@Wreck-X
Copy link

Wreck-X commented Dec 11, 2023

This issue has to be reopened. The PR is causing our workflows to fail.

Can you tell me reason of failing of Workflows?

After carefully watching the order of PRs, PR #2231 was raised just after #2230 but was merged before the PR #2230 and PR #2231 modifies the same change in navigation_service.dart which leads to Errors. Will be raising a new PR shortly!

@Manik2708 PRs are not merged in the order. Any PR which got the approval can be merged

Not complaining, was just laughing at the situation, how the same file was edited by two PRs at the same time :)

oh lol might've been my bad, the bug fix was required for my pr to work ill communicate better next time :D

@Manik2708
Copy link

This issue has to be reopened. The PR is causing our workflows to fail.

Can you tell me reason of failing of Workflows?

After carefully watching the order of PRs, PR #2231 was raised just after #2230 but was merged before the PR #2230 and PR #2231 modifies the same change in navigation_service.dart which leads to Errors. Will be raising a new PR shortly!

@Manik2708 PRs are not merged in the order. Any PR which got the approval can be merged

Not complaining, was just laughing at the situation, how the same file was edited by two PRs at the same time :)

oh lol might've been my bad, the bug fix was required for my pr to work ill communicate better next time :D

No worries! Thanks for your concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
4 participants