Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can't Switch between Themes and language #2226

Closed
tarun824 opened this issue Dec 8, 2023 · 4 comments
Closed

User can't Switch between Themes and language #2226

tarun824 opened this issue Dec 8, 2023 · 4 comments
Labels
feature request unapproved Unapproved, needs to be triaged

Comments

@tarun824
Copy link

tarun824 commented Dec 8, 2023

Is your feature request related to a problem? Please describe.
Yes,
Once chosen initially, there is no option or space to change Language or Theme (Dark/White).

Describe the solution you'd like
I would like create functionality to switch between language and Themes and create a page for app settings and Make a space for Themes and Language .I will also like to add "Edit profile" and Log Out button in that page. There is some code written to switch between Themes that i will update. to my code.

Additional context

These are some designs i have came up with
a)

Screenshot_1702041142
b)

Screenshot_1702041290
c)

Screenshot_1702041526

If there is any other design let me know we can implement that

and i would like recommend to go with c) because it will be user-friendly and even if extra settings added to the app it can grouped here.
@palisadoes @noman2002 @Ayush0Chaudhary

Copy link

github-actions bot commented Dec 8, 2023

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 8, 2023
@tarun824
Copy link
Author

tarun824 commented Dec 8, 2023

And there are some color mismatch in app bar when user switches to White mode ,i will resolve that issue

@palisadoes
Copy link
Contributor

Though this would be a good feature, we are focusing on:

  1. breaking bugs
  2. existing features that don't work as expected
  3. getting our testing coverage up to 95%

When we complete these, then we can work on issues like this one. The features you are suggesting would be better placed on the profile page where all aspects of the individual user's experience could be edited in one place. We can continue discussing what that would look like, but a PR would not be acceptable because of the prioritization.

We need to get our code less buggy.

@tarun824
Copy link
Author

tarun824 commented Dec 9, 2023

Ok sir ,Assign this when you feel it is the right time.
Till then, I will be focusing on these three things.

@noman2002 noman2002 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request unapproved Unapproved, needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants