Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that node files don't get added to the repository #2263

Closed
palisadoes opened this issue Dec 21, 2023 · 1 comment · Fixed by #2267
Closed

Ensure that node files don't get added to the repository #2263

palisadoes opened this issue Dec 21, 2023 · 1 comment · Fixed by #2267
Assignees
@imshivam-gupta
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

Describe the bug

  1. We recently had a Talawa Mobile pull request where many node files were submitted. This appears to have been caused by the person running node related commands for the API or Admin in their local Mobile repository
  2. Precautions must be taken to eliminate this from happening

To Reproduce

  1. Run Node installation related commands in the local repo to generate node related supporting files.
  2. Commit the changes
  3. View the node files added to the commit

Expected behavior

  1. Node related files are not committed
  2. No functionality of the Mobile app is affected
  3. Any changes to configuration files must clearly state why node files have been included for exclusion so that we do not revert to this undesirable state.

Actual behavior

  • See above

Screenshots

  • N/A

Additional details

  • N/A

Potential internship candidates
@palisadoes palisadoes added the bug Something isn't working label Dec 21, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 21, 2023
@imshivam-gupta
Copy link

@palisadoes Can you please assign me this issue?

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Dec 23, 2023
@imshivam-gupta imshivam-gupta mentioned this issue Dec 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imshivam-gupta imshivam-gupta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node files not commit to project imshivam-gupta/talawa
3 participants
@palisadoes @Cioppolo14 @imshivam-gupta