Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Replace CircularProgressIndicator with Spinkit #2338

Closed
RunTerror opened this issue Jan 20, 2024 · 6 comments
Closed

Feature Request: Replace CircularProgressIndicator with Spinkit #2338

RunTerror opened this issue Jan 20, 2024 · 6 comments
Labels
unapproved Unapproved, needs to be triaged

Comments

@RunTerror
Copy link

Screenshot_1705725178

In the provided image, we currently use a circular progress indicator for loading images.
Consider implementing the Spinkit package to showcase a loading animation that aligns seamlessly with the overall theme of our application.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Jan 20, 2024
@Dante291
Copy link

Hello @RunTerror ,we incorporate new packages into our project only if it's challenging to implement a particular feature using existing packages. This approach ensures security, so loading indicator do the work for now.

@RunTerror
Copy link
Author

can we implement a shimmer effect or another animation. The current progress indicator undergoes shape changes, which can appear somewhat unconventional.

@Dante291
Copy link

yeah thats a bug need to be fixed you could work on that but i wouldnt suggest adding a whole new package just for this, do ask from @Cioppolo14

@RunTerror
Copy link
Author

i have tried to create this animation with code only we are not using any package here.

Screen.Recording.2024-01-20.at.15.43.26.mov

can we implement this in our application directly

@Azad99-9
Copy link

@RunTerror I appreciate your effort to contribute to Talawa, please go through this comment before raising any issues.

@Cioppolo14
Copy link

@RunTerror Thank you for your submission. I am going to close this issue for now.

We are now focusing on three types of issues as priority areas:

  1. The improvement in the reliability of our code base. There are many issues created to test existing code. It is a good place to start if you want to understand the operation of various apps. When you submit PRs, we automatically check to see whether the code you submitted has been covered by testing and that each file meets the minimum standard level of the repository as a whole. You won’t be able to avoid understanding testing regimes to contribute to Talawa.
  2. The fixing of bugs and features that seriously hamper the user from using the application. The apps have various shortcomings. The most obvious ones are where the apps do not work as expected. For example buttons that don’t work, errors or messages that are not displayed to make the user understand what to do and many more. Think of any difficulty you have had in getting things working, there could be a bug there waiting for you.
  3. Coding of screens for issues created by our Contributor team based on our soon to be updated design guide. This may include updates to existing screens.
  4. The creation of additional or updated documentation that helps with improving both the experience of the end user and the various GitHub contributors who support the development of our software. This would include user guides.

We will only be accepting feature issues for deficiencies that are obviously lacking in the apps. These are things that make it very difficult to operate the apps. Even so, the PRs will still require you to understand testing as stated before.

Cosmetic changes that require only a few lines of code are not acceptable under this policy.

Closing

@Cioppolo14 Cioppolo14 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unapproved Unapproved, needs to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants