Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Add support to recurring events. #2341

Closed
Azad99-9 opened this issue Jan 21, 2024 · 15 comments · Fixed by #2386 or #2412
Closed

Mobile - Add support to recurring events. #2341

Azad99-9 opened this issue Jan 21, 2024 · 15 comments · Fixed by #2386 or #2412
Assignees

Comments

@Azad99-9
Copy link

Is your feature request related to a problem? Please describe.
Implement recurring events functionality into Talawa mobile.

Describe the solution you'd like

  • The event creation screen(s) should have functionality to create recurring events.
    1. weeks
    2. months
    3. days
    4. weekdays
  • The Calendar screen(s) should display all the created recurring events.
  • The edit event screen(s) should have funcitonality to edit these recurring events.
    1. All instances in the series
    2. Just the instance in question
    3. The instance in question and all those in future
  • Make use of updated event mutations to implement the described functionality.
  • The screen(s) design must follow the guidelines of Talawa Design System found here:
    - https://docs.talawa.io/docs/design/ux/ux-design-system
  • Other functionality must not be affected.
  • Write tests and achieve 100% code coverage to all the new functionality added.

Describe alternatives you've considered
N/A

Approach to be followed (optional)

  • see above.

Additional context

  1. related issues:
  2. related PRs:

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@github-actions github-actions bot added question Further information is requested unapproved Unapproved, needs to be triaged labels Jan 21, 2024
@Azad99-9
Copy link
Author

Azad99-9 commented Jan 21, 2024

@palisadoes please have a look at this issue and do let me know if any follow ups and if I missedout on any thing.

@Community-Programmer
Copy link

@Azad99-9
You are requested to hold off for some time as there is currently a discussion underway regarding whether we should follow a denormalized approach or another one.
Once it is confirmed, there may be some tweaks that need to be made in the weekly recurring events PR. Until then, please wait.
Thank you for your understanding

@Azad99-9
Copy link
Author

Sure @Community-Programmer

@Azad99-9
Copy link
Author

Azad99-9 commented Jan 22, 2024

@Cioppolo14 @noman2002 I would like to work on this, please assign me.

As the implementation of this feature in backend is in progress, meanwhile i will start working on the UI part of this issue.

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Jan 23, 2024
Copy link

github-actions bot commented Feb 3, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 3, 2024
@Azad99-9
Copy link
Author

Azad99-9 commented Feb 3, 2024

Working on this, as the recent PR related to this issue in Talawa API has been closed.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 4, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 15, 2024
@Olatade
Copy link

Olatade commented Feb 15, 2024

HI @Azad99-9 are you still working on this?

@Azad99-9
Copy link
Author

@Olatade yes I am working on this. There is a backend dependency.

@Cioppolo14 Cioppolo14 removed no-issue-activity No issue activity question Further information is requested labels Feb 15, 2024
@Azad99-9
Copy link
Author

@palisadoes @noman2002 The implementation of this feature requires multiple files to be changed.

  • Creation of new Model & View models.
  • Modificaton & addition of new Queries.
  • New UI changes.

I have also had a word with @meetulr, 2 more PRs related to event updation & deletion are also about to come.

So meanwhile i am thinking to split this issue into multiple PRs and raise them one by one.

@palisadoes
Copy link
Contributor

This was expected. Large PRs are too difficult to review effectively.

@Azad99-9
Copy link
Author

@palisadoes @noman2002 please review the UI and suggest changes if any.
Note Api integration not yet done. For now UI is built.
If finalized i will raise a PR for the same. I will make a seperate PR for Api integration.

ui-demo_lUUocDoR.mp4

@palisadoes
Copy link
Contributor

@Azad99-9
Copy link
Author

@palisadoes @Cioppolo14 still API integration work is pending with this issue. Please reopen this so that I can raise a PR for the same.

@palisadoes palisadoes reopened this Feb 25, 2024
@Azad99-9
Copy link
Author

Azad99-9 commented Mar 6, 2024

Api integration completed, writing tests. Will raise the PR by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants