Mobile: Fix the usage of userType

[palisadoes]

NOTE

1. This issue will require close coordination with persons assigned issues in the reference section.
2. You may find it easier to split responsibilities in a different way than proposed here to be more efficient is creating the goal

Describe the bug

1. The schema doesn't apply a person's userType by organization.
2. The userType is currently a part of the User definition not part of a userOrganization definition or something similar.
   1. This means that an Admin is an Admin for all organizations which grants the same rights as a SuperAdmin. This is not the intention.
   2. This has created historical confusion in the Admin and SuperAdmin roles.

This needs to be resolved as it is a showstopper bug.

Expected behavior

These conditions must apply:

1. The userType must be applied per person per organization.
2. Each SuperAdmin must be a SuperAdmin for all organizations
3. All other userTypes would be on a per organization basis

This means that all code logic referencing the userType will need to be updated accordingly.

TALAWA API

Additional considerations include:

1. New user registrations will need to default to the userType USER if not done so already
2. The Schema will need to be updated to reflect this requirement
3. Mutations and queries will need to be updated and in some cases new ones added.
4. Changes must be made against the develop-userTypeFix branch

TALAWA ADMIN

Additional considerations include:

1. The current screen that edits a person's userType will need to be updated. A design is being created for this and will be reflected in the Figma file on our Design Guide page:
   1. https://docs.talawa.io/docs/design/ux/ux-design-system
2. Changes must be made against the develop-userTypeFix branch

TALAWA MOBILE

1. Update the app to work correctly with the modified queries and mutations of the API's develop-userTypeFix branch.
2. Changes must be made against the develop-userTypeFix branch

Actual behavior

• The schema doesn't apply a person's userType by organization.

Screenshots

The previouse API schema:

Additional details

Related issues and PRs:

1. Primary
   1. API: Fix the usage of userType talawa-api#1711
   2. Admin: Fix the usage of userType talawa-admin#1445
   3. Fix/user type talawa-api#1830
   4. Update thedevelop-userTypeFix branch with the latest features from develop - Fundraising / Recurring Events talawa-api#1904
2. Secondary
   1. Update the Organization People Screen Design and Functionality talawa-admin#1451
   2. Update the Community Users Screen Design and Functionality talawa-admin#1452
   3. Update adminApproved to expected functionality in the develop-userTypeFix branch talawa-api#1862

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

• Student Internship Programs #359

[Dante291]

@palisadoes @Cioppolo14 I would like to work on this, please assign me

[Dante291]

@palisadoes Do I make multiple PRs for this or single PR would work?

[AVtheking]

As there would be large amount of files that are going to change and we are working on the admin side by spliting this issue in multiple follow up pr this would be better approach here also

[palisadoes]

A single PR for all the changes will be impossible to properly review.

Find ways to submit multiple smaller PRs.

Large PRs lie dormant for weeks, even months. It's not a good approach.

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[Olatade]

@Dante291 are you still working on this ?

[Dante291]

@Dante291 are you still working on this ?

Yeah i have raised a PR already

[palisadoes]

@Dante291 The PR was merged. What else needs to be done?

[Dante291]

@palisadoes sorry for the late reply was busy with my sem exams, this PR fixed all the changes that was required to fix userType from the mobile side, this issue can be closed.