Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Fixing comment out Custom Lint code #2428

Closed
ArinNigam opened this issue Mar 19, 2024 · 5 comments · Fixed by #2449
Closed

Bug Report: Fixing comment out Custom Lint code #2428

ArinNigam opened this issue Mar 19, 2024 · 5 comments · Fixed by #2449
Assignees
Labels
bug Something isn't working

Comments

@ArinNigam
Copy link

Describe the bug
As mentioned in my previous PR #2413
This Code have been commented by me to pass the checks in github workflows

snippet

image

snippet (1)

The line /// @{nodoc} has been removed for now. Work a way out to keep that line and make the workflows running

To Reproduce
Steps to reproduce the behavior:

  1. To pass the github/workflows by working out on a solution to tackle ///nodoc without removing it
  2. To make sure the custom lint checks work in github workflows and is uncommented out again
  3. 2 Files need to be changed as shown by the code snippet.

Expected behavior
The desired behaviour would be to make sure that the custom lint code is uncommented again to check for custom lint directives and it doesn't fail for /// {nodoc} . Idea would be to find a way since removing this line is still failing the workflows.

Actual behavior
Currently the code has been commented out to pass the custom lint checks.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@ArinNigam ArinNigam added the bug Something isn't working label Mar 19, 2024
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 19, 2024
@ArinNigam ArinNigam changed the title Bug Report: Bug Report: Fixing comment out Custom Lint code Mar 19, 2024
@ArinNigam
Copy link
Author

I would like to work on the issue @Cioppolo14

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Mar 19, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 30, 2024
@Cioppolo14
Copy link

Unassigning due to no activity or PR.

@ArinNigam
Copy link
Author

@Cioppolo14 I was working on it. Sorry for the delay. Kindly re-assign me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants