Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action: Utlize changed-files action for file-count-check and unauthorized-changes-check #2444

Closed
lakshz opened this issue Mar 26, 2024 · 3 comments · Fixed by #2447
Closed
Assignees

Comments

@lakshz
Copy link

lakshz commented Mar 26, 2024

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  1. Utilize the tj-actions/changed-files github action, and create a new job in pull-request.yml, to check if the PR has changes in authorized files.

  2. The job should exit with error code if there are any unauthorized changes

  3. The job should print the unauthorized changes

  4. Utilize the same action, and create a File-Count-Check Job defined in pull_request.yml, to count the files in a PR.

  5. We can get rid of authorized-changes-detection.yml from workflow, if the above things are done

Additional context
This PR achieves the same in talawa-admin repo PalisadoesFoundation/talawa-admin#1793

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 26, 2024
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@Olatade Olatade removed the unapproved Unapproved, needs to be triaged label Mar 26, 2024
@palisadoes
Copy link
Contributor

@lakshz Do you want to work on this?

@lakshz
Copy link
Author

lakshz commented Mar 27, 2024

Yes. Please assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants