Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI & Color Theme (Dark/Light Mode) across screens #2487

Closed
GlenDsza opened this issue Apr 23, 2024 · 5 comments
Closed

Improve UI & Color Theme (Dark/Light Mode) across screens #2487

GlenDsza opened this issue Apr 23, 2024 · 5 comments
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity

Comments

@GlenDsza
Copy link

GlenDsza commented Apr 23, 2024

Describe the bug

Talawa Mobile screens have good color theme for Dark Mode but as soon as we switch to light mode in App following issues are noticed

  • various text disappear due to having white color on white background (Name of User in Profile Screen)
  • Some components have fixed dark color irrespective of App theme (Donate button in Profile Screen), Login Buttons background disappears in Light Mode.
  • The AppBar background color as well as action btn icon colors are inconsistent across screens (Compare profile and Event Screen)
  • The Filter Event Bottom Sheet, Logout Dialog, Event Card, etc. have Yellowish white background which makes the UI look dull (can use white & greyish white shade to differentiate)
  • The posts displayed on post screen doesn't have any border (could have defined border to look like separate card for each post) currently looks like a joint text chunk.

To Reproduce
Steps to reproduce the behavior:

  1. Login
  2. Visit above mentioned screens

Expected behavior
Color Theme for various components across screen should be consistent in Dark as well as Light Mode.

Actual behavior
Color Theme for various components across screen is inconsistent and has some color (visibility) issues in Dark/Light Mode.

Screenshots

Event Screen Profile Screen Post Screen
Event Screen Profile Screen post screen
Event Screen Bottom Sheet Login Screen Logout dialog
Event Screen Bottom Sheet login screen logout dialog
@GlenDsza GlenDsza added the bug Something isn't working label Apr 23, 2024
@GlenDsza
Copy link
Author

Would like to work on this

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 23, 2024
@Azad99-9
Copy link

@GlenDsza Previously I have raised a similar issue. But it got closed. So I would recommend you to confirm the validity of this with mentors before starting your work.

Please have a look at this issue.
#2329

@palisadoes
Copy link
Contributor

That was true in January when we were focusing on tests and broken features. We can revisit this now.

@Azad99-9
Copy link

That's great @palisadoes I guess this opens up a scope for lot of new issues and improvement.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Apr 23, 2024
Copy link

github-actions bot commented May 4, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity
Projects
None yet
Development

No branches or pull requests

3 participants