Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Using local storage to reduce the server load. #438

Closed
yasharth291 opened this issue Mar 21, 2021 · 9 comments
Closed

[Enhancement] Using local storage to reduce the server load. #438

yasharth291 opened this issue Mar 21, 2021 · 9 comments
Assignees

Comments

@yasharth291
Copy link
Contributor

yasharth291 commented Mar 21, 2021

Issue Description: The constant calling of api for details that are going to be used for longer time periods causes extra calls to api making the app slower so adding a local storage will help us.
Issue Severity: high
Environment Details: Issue found mostly in whole app
Observed Behaviour: The app is slow
Expected Behaviour: The app should be fast
Does this issue need immediate attention? yes
Are you willing to work on this issue: Yes, I am willing to work on this issue. Please assign this to me!

@github-actions github-actions bot added enhancement unapproved Unapproved, needs to be triaged labels Mar 21, 2021
@Sagar2366
Copy link
Contributor

@yasharth291 if you haven't already please read our contribution guidelines. Use issue and pr templates to create new issues and PR.
We also advice to discuss issue in slack channel first before creating it directly.

@yasharth291
Copy link
Contributor Author

Sorry for creating the issue but sir everyone takes the issues discussed in the slack and creates are here

@Sagar2366
Copy link
Contributor

Sorry for creating the issue but sir everyone takes the issues discussed in the slack and creates are here

We are trying to give credit to everyone who is finding bugs/issues, suggesting new features, contributing any way to the project. If you felt someone else took credit for your hard work please reach out to us but not following guidelines is not good solution to this.

Now, can you please update issue description ?

@yasharth291
Copy link
Contributor Author

yes sir sure i am updating it and can you please assign me to do this

@yasharth291
Copy link
Contributor Author

@Sagar2366 it is done

@yasharth291
Copy link
Contributor Author

thanks sir i am starting working on it now

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Apr 24, 2021
@palisadoes
Copy link
Contributor

@yasharth291 As this is a feature. Apply the PR to the develop branch

@yasharth291
Copy link
Contributor Author

Sure Sir working on this now

@yasharth291
Copy link
Contributor Author

As i can see someone already has used and solved this problem using shared preferences. I am closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants