Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Restructuring , seperating views and applying state-management #478

Closed
rutvik11062000 opened this issue Mar 23, 2021 · 1 comment
Assignees

Comments

@rutvik11062000
Copy link
Contributor

  • Issue Description:
    The current folder structure suggests that the project is made to implement MVVM architecture.
    What are missing:

    1. respective view models for pages.
    2. locator not used for dependency injection.
    3. No implementation of pages with "BaseView" and "BaseViewModel".
    4. No separation between the UI and business logic.
    5. setstates used everywhere in the form of statemanagement.
    6. Currently we don't posses the services so writing test for dynamic and async responses can;t be done.
  • Issue Severity: Medium

  • Environment Details:

  • Observed Behaviour: No state-management and testing is difficult.

  • Expected Behaviour: Proper structured and testable code should be written to have a logical flow.

  • Steps to reproduce issue:

  • Snapshots/Videos:

  • Does this issue need immediate attention?

  • Are you willing to work on this issue: Yes

  • Other information: We need to restructure and separate services to follow the desired architecture.

@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels Mar 23, 2021
@rutvik11062000 rutvik11062000 changed the title [Enhancement] [Enhancement] Restructuring , seperating views and applying state-management Mar 23, 2021
@Sagar2366 Sagar2366 added code refactor and removed test Testing application unapproved Unapproved, needs to be triaged labels Mar 24, 2021
@palisadoes palisadoes removed the hold label Apr 26, 2021
@palisadoes
Copy link
Contributor

FYI - @rutvik11062000 We also have a parent issue #715 for a general refactoring of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants