Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Invalid password validation error #480

Closed
OnyemaAnthony opened this issue Mar 24, 2021 · 18 comments
Closed

[Bug]Invalid password validation error #480

OnyemaAnthony opened this issue Mar 24, 2021 · 18 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@OnyemaAnthony
Copy link
Contributor

When I want to create an account after providing my details when I click on sign up button it shows that validation error on the password field, saying invalid password
Screenshot_20210323-211017

@github-actions github-actions bot added invalid This doesn't seem right unapproved Unapproved, needs to be triaged labels Mar 24, 2021
@Sagar2366 Sagar2366 added bug Something isn't working good first issue Good for newcomers help wanted and removed invalid This doesn't seem right unapproved Unapproved, needs to be triaged labels Mar 24, 2021
@shauravshikhar
Copy link
Contributor

@OnyemaAnthony can u share screen shot with password shown

@OnyemaAnthony
Copy link
Contributor Author

@shikharsaurav yes I can, though am working on this issue already

@shauravshikhar
Copy link
Contributor

plz share once i think it will be in special char thats why @OnyemaAnthony

@shauravshikhar
Copy link
Contributor

i can help u to debug it

@OnyemaAnthony
Copy link
Contributor Author

@shikharsaurav I don't need help I have already found the cause of the error I will send a PR soon thanks

@shauravshikhar
Copy link
Contributor

ok

@Sagar2366
Copy link
Contributor

@OnyemaAnthony what password are you trying for testing this issue ?

@OnyemaAnthony
Copy link
Contributor Author

OnyemaAnthony commented Mar 24, 2021

@Sagar2366 the password i used was Testing.12345

@OnyemaAnthony
Copy link
Contributor Author

OnyemaAnthony commented Mar 24, 2021

@Sagar2366 The password passed the validation of flutter_pw_validator plugin but didn't pass the regular expression validation because the regular expression does not recognize a dot so I have to add the dot in the regular expression so that the user would not be frustrated since the validation was ticked good but still it's still showing invalid password

@Sagar2366
Copy link
Contributor

great. can you please also do some UI modification. Add some spacing in password strength bar and password text field.

@OnyemaAnthony
Copy link
Contributor Author

Okay I will do that quickly,if I get you correctly you want me to shift the strength bar down from the password texfied, @Sagar2366 please confirm if this is what you mean

@OnyemaAnthony
Copy link
Contributor Author

@Sagar2366 is this okay?
Screenshot_20210324-144514

@OnyemaAnthony
Copy link
Contributor Author

OnyemaAnthony commented Mar 24, 2021

Screenshot_20210324-145941

@Sagar2366
Copy link
Contributor

@OnyemaAnthony add commit to PR directly, I'll review there.

@OnyemaAnthony
Copy link
Contributor Author

@Sagar2366 i have sent the commit

@pr4nshul
Copy link
Contributor

@OnyemaAnthony @Sagar2366 Close this issue, as the PR is merged :)

@adithyaakrishna
Copy link
Contributor

adithyaakrishna commented Mar 27, 2021

@pr4nshul Ig it was not updated, because when I wanted to fix Issue #538 , the gap between validation and password field was same i.e. it didn't have any spacing
So I added this between them,

SizedBox(
    height: 20,
),

Also now this issue can be closed as all the fixes have been completed :)

@OnyemaAnthony
Copy link
Contributor Author

Okay I will close the issue right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants