Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improving response of validators and reducing unnecessary calls to API server #516

Closed
arteevraina opened this issue Mar 26, 2021 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@arteevraina
Copy link
Contributor

arteevraina commented Mar 26, 2021

Issue Description.

  1. In Register Page, when text field is empty (for example: First Name , the validator responds with message like First Name cannot be left blank, But when the email field is empty it does not respond with Email cannot be left blank but rather it shows Not a valid Email Address). I think Not a valid Email Address should be shown when actually email address is invalid not when it is left blank.
    Possible Solution: Play with some conditions in the validator class.
  2. In Login Page, we are not even validating the fields, though we are doing a check _formKey.currentState.validate() before hitting the API but that is not doing anything good since it is always validating to true. This is resulting in unnecessary API calls on the server.
    Possible Solution: use TextEditingController and validators in Text Fields in Login Page.
    After doing these changes some changes also need to be made in the unit tests for validators to test the new behaviour. If this gets approved, I am happy to chime in and fix this up.

Issue Severity

Medium

Does this issue needs immediate attention ?

Yes.

Are you willing to work on this issue ?

Yes.

@github-actions github-actions bot added invalid This doesn't seem right test Testing application unapproved Unapproved, needs to be triaged labels Mar 26, 2021
@Sagar2366 Sagar2366 added bug Something isn't working good first issue Good for newcomers and removed invalid This doesn't seem right test Testing application labels Mar 26, 2021
@Sagar2366
Copy link
Contributor

@arteevraina please use issue template and update all the required details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants