Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]-Features after joining an organization not updated dynamically & Exception occurs when snackbar is displayed. #562

Closed
harshkumarkhatri opened this issue Mar 30, 2021 · 3 comments · Fixed by #619
Assignees
Labels
bug Something isn't working

Comments

@harshkumarkhatri
Copy link

Issue Description:

  • When a user is joining an organization, he is displayed with the snackbar and is taken back to the profile screen but the options which should be there in the profile section are not there instantly because we are not using an efficient state management technique to update things dynamically. Watch video 1 for more light on this.
  • When we have already joined an organization and we are trying to join the same organization again a snackbar is displayed which tells us that we are already a part of this but it also shows an exception related to rendering in the debug console. Watch video 2 for more info on the exception.

Issue Severity: Medium

Observed Behaviour:

  • When we join the organisation, the features which are displayed when an organisation is joined are not updated dynamically.
  • An exception in debug console when someone tries joining the same organization they are a part of and a snackbar is displayed. [Not sure but the exception occurs because the keyboard is active]

Expected Behaviour:

  • Features like switch organisation, leave, organisation name, etc should be updated dynamically.
  • The exception should not occur when the snackbar is displayed.

Steps to reproduce issue:
Watch the linked videos.

Snapshots/Videos:

Does this issue need immediate attention?
No

Are you willing to work on this issue:
No

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 30, 2021
@Sagar2366 Sagar2366 added enhancement bug Something isn't working and removed unapproved Unapproved, needs to be triaged enhancement labels Mar 30, 2021
@Sagar2366
Copy link
Contributor

@harshkumarkhatri you are referring two issues here -

  1. dynamically updating organisation name : this is duplicate issue and should get fixed in another PR.
  2. User trying to join same organisation - can you work on this ?

@arteevraina
Copy link
Contributor

@harshkumarkhatri Since you are not willing to work on this issue. Can I take up this issue I have already fixed the 2nd part of the issue you described in the issue description ?

@harshkumarkhatri
Copy link
Author

Cool you can work on this,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants