Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]- Breaking changes introduced due to latest image picker package. #638

Closed
CyberWake opened this issue Apr 10, 2021 · 3 comments
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@CyberWake
Copy link
Contributor

CyberWake commented Apr 10, 2021

  • Issue Description:
    After the update in the packages versioning. Image picker now fetches the latest package due to with the function like getImage() not been found in the package. Added these functions are now made static as well enabling their call without a constructor. All the breaking changes also need to be fixed made in the latest version. It also needs to have some changes in android manifest relating to permissions.

  • Issue Severity:
    High as this causes the build to fail.

  • Environment Details:
    register_form.dart

  • Observed Behaviour:
    On android 10 and above the package disen't work properly.

final pickImage = await ImagePicker().getImage(source: ImageSource.camera);
final pickImage = await ImagePicker().getImage(source: ImageSource.gallery);

  • Expected Behaviour:
    Addition of new permissions as per package.
    Use of new function defined in the package to pick image.

  • Steps to reproduce issue:
    Switch to master, get the latest update then build or check dart analysis.

  • Does this issue need immediate attention?
    Yes, with the fix of this one build failure would also be fixed.

  • Are you willing to work on this issue:
    Yes, I do will to work on this. If new contributors will they can take over this one as well.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 10, 2021
@CyberWake CyberWake changed the title [Bug]- updating functions for latest image picker package. [Bug]- Breaking changes intorduced due to latest image picker package. Apr 11, 2021
@CyberWake
Copy link
Contributor Author

@Sagar2366 sir please assign this issue to me.

@Sagar2366 Sagar2366 added bug Something isn't working good first issue Good for newcomers and removed unapproved Unapproved, needs to be triaged labels Apr 11, 2021
@CyberWake CyberWake changed the title [Bug]- Breaking changes intorduced due to latest image picker package. [Bug]- Breaking changes introduced due to latest image picker package. Apr 11, 2021
@utkarshshendge
Copy link
Contributor

Hi @CyberWake, adding an organization image while creating an organization throws an error, maybe it's related to this issue.

@CyberWake
Copy link
Contributor Author

Hi @CyberWake, adding an organization image while creating an organization throws an error, maybe it's related to this issue.

It's is a problem pertaining to the API I guess because the error is perceived from the graphql.
Added if there was something causing problem due to the package then the image would have also been not displayed on the page itself. After the path to the file is same. For both display image.file and the path passed in the graphql mutation in the variable field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants