Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of Loading widget to make it a universal loading widget #719

Closed
utkarshshendge opened this issue Apr 25, 2021 · 3 comments · Fixed by #754
Closed

Modification of Loading widget to make it a universal loading widget #719

utkarshshendge opened this issue Apr 25, 2021 · 3 comments · Fixed by #754
Assignees

Comments

@utkarshshendge
Copy link
Contributor

  • Parent issue : Refactoring of codebase and separation on data/UI #715

  • Issue Description:
    Modification of widget declared in loading.dart to make it a universal loading widget. This widget can be provided with properties like isCurrentOrgNull resulting in asking the user to join an organization, isNetworkError resulting in showing an error image and appropriate text, refresh function, and message resulting in text displaying the message provided (like 'no post to show create one', 'no events to show create one', etc) and a refresh button which calls the refresh function again to fetch the data if other users add data to the server.

  • Issue Severity:
    Low

  • Environment Details:
    Project Level : loading.dart

  • Observed Behaviour:
    Loading stateful widget with few parameters.

  • Expected Behaviour:
    Make the Loading widget as universal loading widget.

  • Does this issue need immediate attention?
    No

  • Please ask mentors/maintainers to assign if you are willing to work on this issue.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 25, 2021
@Sagar2366 Sagar2366 added code refactor and removed unapproved Unapproved, needs to be triaged labels Apr 25, 2021
@Raunakk02
Copy link
Contributor

Can I work on this issue @Sagar2366 sir?

@palisadoes
Copy link
Contributor

Issue #700 has now been integrated into the pull request process. It will flag all Dart files that are longer than 300 lines to help with readability. Please make sure your contribution reduces file sizes to within this limit.

@Raunakk02
Copy link
Contributor

Issue #700 has now been integrated into the pull request process. It will flag all Dart files that are longer than 300 lines to help with readability. Please make sure your contribution reduces file sizes to within this limit.

Sure @palisadoes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants