Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Code Quality Automations #736

Closed
palisadoes opened this issue Apr 26, 2021 · 4 comments
Closed

Pull Request Code Quality Automations #736

palisadoes opened this issue Apr 26, 2021 · 4 comments

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Apr 26, 2021

We have spent some time refactoring the code base. Each pull request now automatically analyzes your code for undesirable characteristics.

  1. The Dart Package Analyzer dart-package-analyzer ensures consistent formatting
  2. We automatically evaluate each Dart file submitted to ensure they are all under 300 lines in length (To be enforced after May 22 2021)

Please ensure your submissions meet these guidelines. Our CONTRIBUTING.md file explains what you'll need to do.

@palisadoes palisadoes pinned this issue Apr 26, 2021
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 26, 2021
@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Apr 26, 2021
@sumitra19jha
Copy link
Contributor

sumitra19jha commented May 1, 2021

@palisadoes @Sagar2366 Can we update the contributing guideliness further.
Recently we have done a lot of changes and some are going on:

  1. File Size limited to 300 lines
  2. Linting should be followed
  3. Separation of business logic form UI
  4. Use SizeConfig file to scale the UI, rather than constant value
  5. Use Data Models

Some of them are missing in the documentation, and some needs to be elaborated more. Can I work on updating the documentation further?

@palisadoes
Copy link
Contributor Author

@sumitra19jha go ahead

@sumitra19jha
Copy link
Contributor

@sumitra19jha go ahead

Ok

@palisadoes
Copy link
Contributor Author

We have updated the deadline to May 22nd

@palisadoes palisadoes unpinned this issue May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants