Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVVM implementation for Add Event Page (add_event_page.dart). #762

Closed
rutvik11062000 opened this issue May 7, 2021 · 1 comment
Closed
Labels
unapproved Unapproved, needs to be triaged

Comments

@rutvik11062000
Copy link
Contributor

rutvik11062000 commented May 7, 2021

Is your feature request related to a problem? Please describe.
This is the child issue of #758
To implement MVVM architecture on add_event_page.dart file.

Describe the solution you'd like
See #760 for in-depth details about the implementation.
For Sample see the PR changes #759

Additional context
Other things to take into consideration:

  1. Make sure all the files that you are either updating or creating must be under 300 lines.
  2. If there are multiple same widget with only few modification extract it as a method and give only change variable as a parameter.
  3. Make the code as concise as possible.
  4. Kindly add setup locator in the add_post_test.dart otherwise travis build will fail.
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label May 7, 2021
@CoderMayhem
Copy link
Contributor

This page is built on top of events page having common endpoints and functions. I guess this can be handled along with the events.dart page. I guess you can close this issue and update it in the issue description in events page MVVM implementation issue. @rutvik11062000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unapproved Unapproved, needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants