Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVVM implementation for News Article Page (news_article.dart). #764

Closed
rutvik11062000 opened this issue May 7, 2021 · 2 comments · Fixed by #791
Closed

MVVM implementation for News Article Page (news_article.dart). #764

rutvik11062000 opened this issue May 7, 2021 · 2 comments · Fixed by #791
Assignees
Labels
test Testing application

Comments

@rutvik11062000
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This is the child issue of #758
To implement MVVM architecture on news_article.dart file.

Describe the solution you'd like
See #760 for in-depth details about the implementation.
For Sample see the PR changes #759

Additional context
Other things to take into consideration:

  1. Make sure all the files that you are either updating or creating must be under 300 lines.
  2. If there are multiple same widget with only few modification extract it as a method and give only change variable as a parameter.
  3. Make the code as concise as possible.
  4. Kindly create test file and add the tests.
@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels May 7, 2021
@StrangeNoob
Copy link
Contributor

@Sagar2366 if @rutvik11062000 wont mind then I would I like to work on this

@rutvik11062000
Copy link
Contributor Author

Sure @StrangeNoob you can work on this if sir permits😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants