Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't signup with profile picture #777

Closed
utkarshshendge opened this issue May 12, 2021 · 3 comments
Closed

Couldn't signup with profile picture #777

utkarshshendge opened this issue May 12, 2021 · 3 comments
Labels
bug Something isn't working unapproved Unapproved, needs to be triaged

Comments

@utkarshshendge
Copy link
Contributor

Describe the bug
When trying to signup with a profile picture, a message true` is shown, but the user is not signed up.

To Reproduce
1.Try signing up without a profile picture.
2. A message true will be displayed, and you won't be taken to join organization page.

Expected behavior
User should be able to signup with profile picture, just as he/she is able to signup without a profile picture.

Additional details
Please ask mentors/maintainers to assign this issue if you are interested in working on it.

@github-actions github-actions bot added bug Something isn't working unapproved Unapproved, needs to be triaged labels May 12, 2021
@palisadoes
Copy link
Contributor

@utkarshshendge most applications make you sign up. Then you add your profile picture afterwards. This reduces the risk of any possible flaws in the code could allow an unauthorized person to upload data. I'd suggest that you remove this feature if it exists and only allow profile picture uploads after registration is complete

@utkarshshendge
Copy link
Contributor Author

utkarshshendge commented May 12, 2021

Completely agree with you @palisadoes. Adding profile pictures later also makes signup seamless. I have addressed this issue in my proposal. But I think makes sense to start working on this issue right now regardless of whether the proposal gets accepted or not.
Should I change the description of the issue and start working on it or wait for some time?

@palisadoes
Copy link
Contributor

We have been respecting pausing of any issues that may be covered under GSoC proposals when alerted by students. Please wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unapproved Unapproved, needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants