Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Hard Coded strings #800

Closed
palisadoes opened this issue May 18, 2021 · 2 comments · Fixed by #829
Closed

Refactor Hard Coded strings #800

palisadoes opened this issue May 18, 2021 · 2 comments · Fixed by #829
Assignees
@sumitra19jha

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This is a child issue of #798

Describe the solution you'd like

  1. Refactor all widgets in the Talawa app which have hardcoded strings.
  2. Update the Talawa GitHub action workflow to automatically reject any hard coded strings outside of the language translation files.
@palisadoes palisadoes mentioned this issue May 18, 2021
Closed
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label May 18, 2021
@sumitra19jha
Copy link
Contributor

@palisadoes Please assign me this issue

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label May 18, 2021
This was referenced May 20, 2021
Merged
Merged
@sumitra19jha sumitra19jha mentioned this issue Jun 19, 2021
Merged
@sumitra19jha
Copy link
Contributor

@palisadoes Please close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumitra19jha sumitra19jha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

String refactoring sumitra19jha/talawa
2 participants
@palisadoes @sumitra19jha