Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title with RandomGender generates firstname instead of Title #60

Closed
marcofranssen opened this issue Mar 2, 2019 · 3 comments
Closed

Comments

@marcofranssen
Copy link

See below the bug in default switch.

// Title returns a random title, gender decides the gender of the name
func Title(gender int) string {
	var title = ""
	switch gender {
	case Male:
		title = randomFrom(jsonData.MaleTitles)
		break
	case Female:
		title = randomFrom(jsonData.FemaleTitles)
		break
	default:
		title = FirstName(privateRand.Intn(2))
		break
	}
	return title
}
@Pallinder
Copy link
Owner

Thanks for this! Think you could open a PR so we can fit into release 1.2.0?

@daisy1754
Copy link
Contributor

Hi @Pallinder I've opened #64 to fix this. Do you mind taking a look (also it'd be great if you can look at #63 too :) )

@Pallinder
Copy link
Owner

Released in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants