Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports user-assigned managed identities #54

Merged
merged 2 commits into from Jan 20, 2024
Merged

Supports user-assigned managed identities #54

merged 2 commits into from Jan 20, 2024

Conversation

PalmEmanuel
Copy link
Owner

Pull Request

Pull Request (PR) description

Added

  • Added support for user-assigned managed identities (#48).

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or failed tests.
  • Markdown help added/updated.
  • Unit tests added/updated.

@PalmEmanuel PalmEmanuel added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request bug Something isn't working labels Jan 20, 2024
Copy link
Contributor

Test Results

  3 files  ± 0  129 suites  ±0   10s ⏱️ +3s
191 tests +12  191 ✅ +12  0 💤 ±0  0 ❌ ±0 
549 runs  +12  549 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 514e0f6. ± Comparison against base commit 6ca1e62.

This pull request removes 1 and adds 13 tests. Note that renamed tests count towards both.
New-AzDataTableContext.parameters.only has expected parameters(New-AzDataTableContext,TableName ConnectionString StorageAccountName StorageAccountKey SharedAccessSignature Token ManagedIdentity)
Add-AzDataTableEntity.parameters.only has expected parameters(Context Entity Force CreateTableIfNotExists,Add-AzDataTableEntity)
AzBobbyTables.module.has parameter ClientId documented in markdown help file for command New-AzDataTableContext
Clear-AzDataTable.parameters.only has expected parameters("Context",Clear-AzDataTable)
Get-AzDataTableEntity.parameters.only has expected parameters(Context Filter Property First Skip Sort Count,Get-AzDataTableEntity)
New-AzDataTable.parameters.only has expected parameters("Context",New-AzDataTable)
New-AzDataTableContext.parameters.has correct parameter sets for parameter ClientId
New-AzDataTableContext.parameters.has parameter ClientId of type string
New-AzDataTableContext.parameters.has parameter ClientId set to mandatory False for parameter set ManagedIdentity
New-AzDataTableContext.parameters.only has expected parameters(New-AzDataTableContext,TableName ConnectionString StorageAccountName StorageAccountKey SharedAccessSignature Token ManagedIdentity ClientId)
New-AzDataTableContext.parameters.only has expected parameters(TableName ConnectionString StorageAccountName StorageAccountKey SharedAccessSignature Token ManagedIdentity ClientId,New-AzDataTableContext)
…

@PalmEmanuel PalmEmanuel merged commit caa5655 into main Jan 20, 2024
7 checks passed
@PalmEmanuel PalmEmanuel deleted the uami branch January 20, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant