Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MemoryStorage support to TinyDBStore adapter #111

Closed
sserrata opened this issue Oct 1, 2018 · 1 comment
Closed

Add MemoryStorage support to TinyDBStore adapter #111

sserrata opened this issue Oct 1, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sserrata
Copy link
Member

sserrata commented Oct 1, 2018

  • Palo Alto Networks Cloud Python SDK version: v1.3.0
  • Python version: 2.7, 3.5+
  • Operating System: any

Description

TinyDB comes with two storage types: JSON and in-memory. The current default used by pancloud is JSON. There are some use-cases that could benefit from in-memory mode, such as the use-case where only access_token needs to be stored/cached in the pancloud credentials store. However, the current TinyDBStore class implementation does not provide a way to pass the storage param, i.e. storage=MemoryStorage.

Proposed solution

Add support for storage param to TinyDBStore using storage_params to pass the argument.

@sserrata sserrata added the enhancement New feature or request label Oct 1, 2018
@sserrata sserrata self-assigned this Oct 1, 2018
@sserrata
Copy link
Member Author

sserrata commented Oct 2, 2018

Tabling for a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant