Fixed typo - changed leftover pandevice to panos #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the same problem also exists here: pan-os-python/panos/network.py Line 500 in 617d9a8 Should I fix it as well? |
|
@DeepSpace2 You are completely correct, on both accounts. Thank you for catching this oversight! Yes, if you wouldn't mind fixing the |
|
@btorresgil Done :) thanks for merging. |
btorresgil
approved these changes
Aug 31, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Aug 31, 2020
### [1.0.1](v1.0.0...v1.0.1) (2020-08-31) ### Bug Fixes * Fix NameError in refresh_devices() ([d4a9c3f](d4a9c3f)), closes [#257](#257)
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on PyPI and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed a leftover
pandevicereference topanosMotivation and Context
Fixes a
NameError: pandevice is not definedexception when callingpanorama.refresh_devicesmethod.How Has This Been Tested?
Instead of said
NameErrorwe actually get back the list of device groups :)Types of changes