Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added policies.AuthenticationRule #415

Merged
merged 2 commits into from Feb 7, 2022
Merged

Added policies.AuthenticationRule #415

merged 2 commits into from Feb 7, 2022

Conversation

AnthoBalitrand
Copy link
Contributor

@AnthoBalitrand AnthoBalitrand commented Feb 5, 2022

Description

Added policies.AuthenticationRule class to be able to retrieve / update authentication rules.

Motivation and Context

This rulebase was not available yet on the tool.

How Has This Been Tested?

Tested on production PaloAlto / Panorama deployment.

Screenshots (if appropriate)

N/A

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Contributor Author

@AnthoBalitrand AnthoBalitrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed formatting with black 19.10b0
Black >= 21.0 reviews almost all formatting, perhaps needs to be avoided on setup.py

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect work, even includes the opstate stuff (in the new approach I just pushed live last week) and the HIT_COUNT_STYLE.

Thanks for this!

@shinmog shinmog merged commit 0d70d3f into PaloAltoNetworks:develop Feb 7, 2022
@welcome-to-palo-alto-networks
Copy link

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

github-actions bot pushed a commit that referenced this pull request Mar 29, 2022
## [1.7.0](v1.6.0...v1.7.0) (2022-03-29)

### Features

*  Add Prisma Access support ([#419](#419)) ([f93416e](f93416e)), closes [#406](#406) [#413](#413) [#396](#396)
* Add decryption rule target and negate_target ([#404](#404)) ([88a2903](88a2903))
* Add hierarchy retrieval info ([#366](#366)) ([a290b31](a290b31))
* Add hit count support for Panorama / device group rulebases ([#429](#429)) ([057822a](057822a)), closes [#388](#388)
* **panos.panorama.Panorama:** Add `refresh_shared_objects()` ([#436](#436)) ([11327a4](11327a4)), closes [#428](#428)
* Add alternative quoting for `op()` ([#367](#367)) ([b8d0379](b8d0379)), closes [#234](#234)
* Add Cloud Services plugin support ([683f3b5](683f3b5))
* Add Local User Database objects ([#385](#385)) ([d39b6de](d39b6de))
* Add objects.ApplicationOverride ([#405](#405)) ([98db86a](98db86a))
* Add policies.AuthenticationRule ([#415](#415)) ([0d70d3f](0d70d3f))
* ApplicationTag - tag predefined applications ([#414](#414)) ([cfee6e3](cfee6e3))
* Make opstate more discoverable for users ([#413](#413)) ([f4f08d0](f4f08d0)), closes [#396](#396)

### Bug Fixes

* **panos.objects.ApplicationFilter:** Fix tag path  ([#381](#381)) ([a0991f8](a0991f8))
* `delete_similar()` now breaks delete calls into chunks ([#435](#435)) ([4333377](4333377))
* Fixes `refresh()` for attrib style params ([#395](#395)) ([0b47a3a](0b47a3a)), closes [#392](#392)
* Modify show_highavailability_state method xpath for Panorama ([#430](#430)) ([37ed2ca](37ed2ca))
* **AggregateInterface:** Correct lacp_passive_pre_negotiation xpath ([6a67320](6a67320)), closes [#406](#406)
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants