Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes AttributeError on _set_version_and_version_info function #440

Merged
merged 1 commit into from Apr 7, 2022
Merged

Fixes AttributeError on _set_version_and_version_info function #440

merged 1 commit into from Apr 7, 2022

Conversation

AnthoBalitrand
Copy link
Contributor

Description

Fixes issue #439

How Has This Been Tested?

Mockup environment (Panorama with pre-registered device not yet connected)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

shinmog
shinmog approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shinmog shinmog merged commit ce17bd5 into PaloAltoNetworks:develop Apr 7, 2022
github-actions bot pushed a commit that referenced this pull request Apr 7, 2022
@semantic-release-bot
chore(release): 1.7.1
256349c 
### [1.7.1](v1.7.0...v1.7.1) (2022-04-07)

### Bug Fixes

* **panos.base.PanDevice._set_version_and_version_info:** Fixes AttributeError when version is not known ([#440](#440)) ([ce17bd5](ce17bd5)), closes [#439](#439)
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

🎉 This PR is included in version 1.7.1 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinmog shinmog shinmog approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnthoBalitrand @shinmog