Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting of request system software install command - load_config parameter #447

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix formatting of request system software install command - load_config parameter #447

merged 2 commits into from
Jun 1, 2022

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented May 6, 2022

Description

The command triggered in SoftwareUpdater.install() method has wrong formatting around load_config parameter. All non key words should be quoted, this includes the value of load_config (see op method documentation).

For the moment the load_config parameter is not quoted which causes the op method to fail.

Motivation and Context

W/o this fix running an upgrade with named configuration load after reboot is not possible.

How Has This Been Tested?

This fix was used in an Ansible playbook.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@FoSix FoSix mentioned this pull request May 9, 2022
Closed
shinmog
shinmog approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shinmog shinmog merged commit 3e2e926 into PaloAltoNetworks:develop Jun 1, 2022
@welcome-to-palo-alto-networks
Copy link

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

github-actions bot pushed a commit that referenced this pull request Jan 13, 2023
@semantic-release-bot
chore(release): 1.8.0
689d9c3 
## [1.8.0](v1.7.3...v1.8.0) (2023-01-13)

### Features

* Add per-admin push for Panorama ([#485](#485)) ([bf26305](bf26305))

### Bug Fixes

* **panos.updater.SoftwareUpdater.install:** Fix for load_config parameter ([#447](#447)) ([3e2e926](3e2e926))
@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinmog shinmog shinmog approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FoSix @shinmog