Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admins parameter to Panorama push #485

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

jamesholland-uk
Copy link
Member

@jamesholland-uk jamesholland-uk commented Dec 22, 2022

Description

Adding support for the PAN-OS 10.2 feature of Administrator-Level Push from Panorama to Managed Devices

Motivation and Context

Motivation is adding support for a new PAN-OS feature, and also to support adding this feature in pan-os-ansible (ref)

How Has This Been Tested?

Tested locally, with Panorama 11.0.0 and managed firewall 10.2.3

    panorama = Panorama(HOSTNAME, USERNAME, PASSWORD)

    cmd = PanoramaCommitAll(
        style="device group",
        name="poc-dg",
        include_template=False,
        force_template_values=False,
        admins=["other"],
    )

    sync = False
    sync_all = True

    result = panorama.commit(cmd=cmd, sync=sync, sync_all=sync_all)

Screenshots (if appropriate)

Screenshot 2022-12-22 at 13 09 56

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Member

@btorresgil btorresgil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jamesholland-uk jamesholland-uk merged commit bf26305 into develop Jan 9, 2023
@jamesholland-uk jamesholland-uk deleted the add-admins-arg-to-panorama-push branch January 11, 2023 08:24
github-actions bot pushed a commit that referenced this pull request Jan 13, 2023
## [1.8.0](v1.7.3...v1.8.0) (2023-01-13)

### Features

* Add per-admin push for Panorama ([#485](#485)) ([bf26305](bf26305))

### Bug Fixes

* **panos.updater.SoftwareUpdater.install:** Fix for load_config parameter ([#447](#447)) ([3e2e926](3e2e926))
@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants