Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Refactor map(any) variables #279

Closed
horiagunica opened this issue Jun 30, 2023 · 2 comments
Closed

Refactor map(any) variables #279

horiagunica opened this issue Jun 30, 2023 · 2 comments

Comments

@horiagunica
Copy link
Contributor

Is your feature request related to a problem?

Currently map variables have any structure which does not constrain the values within the map.

Describe the solution you'd like

Use object({}) and define variable constraints - for example :

  type = object({
    vnet_name                    = string
    resource_group_name          = string
    name                         = optional(string)
    allow_virtual_network_access = bool
    allow_forwarded_traffic      = bool
    allow_gateway_transit        = bool
    use_remote_gateways          = bool
  })

Describe alternatives you've considered.

No response

Additional context

If we are going to use this implementation - we would require to bump the TF version to 1.3 minimum so that we can use optional values within the map object without constraints : https://medium.com/@apr_1985/terraform-optional-attributes-and-defaults-d73643185341

@welcome-to-palo-alto-networks

🎉 Thanks for opening your first issue here! Welcome to the community!

@FoSix
Copy link
Contributor

FoSix commented Sep 29, 2023

superseded by #307

@FoSix FoSix closed this as completed Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants