Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

fix(examples): Add 'name_prefix' for external lb rules #234

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix(examples): Add 'name_prefix' for external lb rules #234

merged 1 commit into from
Jan 4, 2024

Conversation

michalbil
Copy link
Contributor

Description

Add name_prefix in front of external LB rule names in the examples to avoid name collisions in CI/release workflows.

Motivation and Context

Resolves #233

How Has This Been Tested?

Apply vpc_peering_common example.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@michalbil michalbil requested a review from a team as a code owner January 3, 2024 16:14
pimielowski
pimielowski approved these changes Jan 3, 2024
View reviewed changes
Copy link

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

sebastianczech
sebastianczech approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

horiagunica
horiagunica approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@horiagunica horiagunica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for solving that!

@michalbil michalbil merged commit a1fb93b into main Jan 4, 2024
48 checks passed
@michalbil michalbil deleted the add-name-prefix-for-external-lb-rules branch January 4, 2024 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pimielowski pimielowski pimielowski approved these changes

@sebastianczech sebastianczech sebastianczech approved these changes

@horiagunica horiagunica horiagunica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] Release workflows fails - all-ports address already exists
4 participants
@michalbil @pimielowski @sebastianczech @horiagunica