Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
vscode-tmgrammar-snap doesn't run test cases on Windows #1
I tried running
I made a small reproduction example.
Steps to reproduce the bug on Windows 10 in a PowerShell with administrative privileges:
This should yield the
@PanAeon If you want I could take a stab at a bugfix, but maybe you already have an idea what's going on here?
By the way: Great tool! Snapshots really help to avoid regressions.
Ok, so it has something to do with the way you pass the glob pattern over the command line. Using double quotes instead of single quotes for the testcases pattern works for me (on Ubuntu and on Windows). I've updated the reproduction repo, the updated commit is
So the test cases are actually found now, but there is another issue. The test cases which succeed on Ubuntu now fail on Windows. The error message is:
My first guess is that it has to do with the fact that line endings are encoded differently on Windows. I'll have a look.
@fachammer Thank you so much for reporting this issue and for the fix! Your problem report is excellent. In retrospective I can't believe what a sloppy job I did with hardcoded line endings :) I've already published firstname.lastname@example.org to npm with your fix.