New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-tmgrammar-snap doesn't run test cases on Windows #1
Comments
Ok, so it has something to do with the way you pass the glob pattern over the command line. Using double quotes instead of single quotes for the testcases pattern works for me (on Ubuntu and on Windows). I've updated the reproduction repo, the updated commit is So the test cases are actually found now, but there is another issue. The test cases which succeed on Ubuntu now fail on Windows. The error message is:
My first guess is that it has to do with the fact that line endings are encoded differently on Windows. I'll have a look. |
@fachammer Thank you so much for reporting this issue and for the fix! Your problem report is excellent. In retrospective I can't believe what a sloppy job I did with hardcoded line endings :) I've already published vscode-tmgrammar-test@0.0.6 to npm with your fix. |
Great, no worries. Thanks for the quick release! Works like a charm now. |
I tried running
vscode-tmgrammar-snap
as part of a CI process on Azure Pipelines. There it runs tests on Linux, MacOS and Windows environments. Runningvscode-tmgrammar-snap
works fine on Linux and MacOS but fails on Windows with the messageERROR no test cases found
, but I expected it to just work on Windows. Then I tested it on a local Windows 10 VM and there it also fails with the same message.I made a small reproduction example.
Steps to reproduce the bug on Windows 10 in a PowerShell with administrative privileges:
This should yield the
ERROR no test cases found
message. Doing the same steps (excluding the windows-build-tools install) on my local Ubuntu installation works fine and producesas expected.
@PanAeon If you want I could take a stab at a bugfix, but maybe you already have an idea what's going on here?
By the way: Great tool! Snapshots really help to avoid regressions.
The text was updated successfully, but these errors were encountered: