Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird fill phenomenon #37

Open
Slimmy82 opened this issue Oct 20, 2015 · 3 comments
Open

Weird fill phenomenon #37

Slimmy82 opened this issue Oct 20, 2015 · 3 comments
Labels
bug 🐛 help wanted 🆘 Looking for community assistance or input

Comments

@Slimmy82
Copy link
Collaborator

When filling I encountered this weird phenomenon

Here is before fill
screen shot 2015-10-19 at 7 58 41 pm
here is after fill
screen shot 2015-10-19 at 7 58 52 pm

Any suggestions to this issue?

I have the .pcb file and a video screen capture if needed.

@techninja
Copy link
Collaborator

This is a known issue, and described on the readme, with a temporary user fix. Unfortunately there's not enough time available to try and work this out completely. The issue is specifically to do with piecing the fill together from the out of order fill points, and if they're not put back together in the correct order, you're left with end points that are far apart, and you get this strange angle grouping like you see here.

I've done quite a bit of work to alleviate this, and it happens far less frequently than it did, but I've run out of time to hack away at improving it more. The problem is fairly complex as every inside island must be accounted for and could be confused for a similar point distance issue.

If I stand a chance at fixing the issue, I'll need as many saved example files that it occurs with, as it's somewhat difficult to just make it happen.

@Slimmy82
Copy link
Collaborator Author

Lets leave this open and I will add more examples as I encounter them.

@casperlamboo
Copy link

I'm working on a project that uses a fill tool similar to the one used in the pancake bot app. We encountered a similar problem with the flood-fill algorithm (we used also used n-dimensional-flood-fill).

To solve this I wrote a small library using the boolean operations of clipper. This library uses vector input to generate fills. It can be found here https://github.com/Doodle3D/fill-path.

@techninja techninja added bug 🐛 help wanted 🆘 Looking for community assistance or input labels Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 help wanted 🆘 Looking for community assistance or input
Projects
None yet
Development

No branches or pull requests

3 participants