Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material icons : Two tone and other options #117

Open
meetdilip opened this issue Feb 2, 2020 · 15 comments
Open

Material icons : Two tone and other options #117

meetdilip opened this issue Feb 2, 2020 · 15 comments

Comments

@meetdilip
Copy link
Contributor

Hi, I hope you already know that Google Material icons are now available in the following variants.

  1. Filled
  2. Outlined
  3. Rounded
  4. Two Toned
  5. Sharp

https://material.io/resources/icons/?style=baseline

It would be great if we can have them as a part of Open Symbols. Thanks

@meetdilip
Copy link
Contributor Author

There was a set of SVG sprites which were named " symbols ". I couldn't use it even after adding them to the usr/share/inkscape/symbols directory. They were shown as " unnamed " and no matter we select any from them, it showed the same " battery " icon set. Attaching the same.

sprites.zip

@Xaviju
Copy link
Collaborator

Xaviju commented Feb 3, 2020

Currently there is a Material Design Set https://github.com/Xaviju/inkscape-open-symbols/tree/master/material-design.
You should be able to just copy any of the svgs in that folder into the inkscape symbols folder and use it.

If you are updating symbols from Material Design, it would be nice if you put them under the same folder an reorganize it. Thanks!

@meetdilip
Copy link
Contributor Author

If you are updating symbols from Material Design, it would be nice if you put them under the same folder an reorganize it. Thanks!

Yes. I am trying to add other styles. I am already using the one that is available.

@meetdilip
Copy link
Contributor Author

meetdilip commented Feb 4, 2020

@Xaviju Can we discuss here ? ( if ok with you ).

@PanderMusubi
Copy link
Owner

@Xaviju can we move this one forward? I can also help out.

@Xaviju
Copy link
Collaborator

Xaviju commented Apr 29, 2020

I think it basically requires to update all current Material Design Libraries in this repo to ensure that all SVG symbols have a fill and stroke value. Currently, it only have a fill value.
Its a lot of work and I cannot commit into this now but if @PanderMusubi or @meetdilip have more time go for it and I'l lbe happy to help.

@Xaviju
Copy link
Collaborator

Xaviju commented Apr 29, 2020

My recommendation would be to check if material design has already a SVG sprite so can be copypasted. Other option is to download every icon and create the sprite using icomoon and just edit the final SVG sprite getting the missing partes from the SVG template we have in the repo

@PanderMusubi
Copy link
Owner

How can material-design-icons/sprites/svg-sprite/svg-sprite-action.svg be converted to inkscape-open-symbols/material-design/material-design-action.svg? Do you have a script for this?

I prefer first to upgrade the existing filled style and add other styles after that.

@PanderMusubi
Copy link
Owner

sort of related, a thumbs up for google/material-design-icons#1009

@PanderMusubi
Copy link
Owner

See 9494b3c

@yashpalgoyal1304 @qwazix This is not final. See line 17 and 18 in 2-update-material-design.sh

Does one of you know what the correct settings are, or does this differ per icon or icon set?

@goyalyashpal
Copy link
Contributor

See line 17 and 18 in 2-update-material-design.sh

link??

@goyalyashpal
Copy link
Contributor

i am afraid i dont have any knowledge at all about this stuff.

@PanderMusubi
Copy link
Owner

No worries. we will find somone.

Perhaps this is one for you? #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants