Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out what's going on with the Download PDF button. #5

Closed
jmatsushita opened this issue Oct 20, 2015 · 6 comments
Closed

Work out what's going on with the Download PDF button. #5

jmatsushita opened this issue Oct 20, 2015 · 6 comments
Assignees

Comments

@jmatsushita
Copy link
Member

The original doesn't have a button (anymore): http://the-engine-room.github.io/PACT-kit/pact%20activities/Introduction/

The current merge has a button that doesn't work. http://iilab.github.io/teampanicbutton.github.io/pact-activities/pact-activities-01-introduction.html

Note that the pdf folder has not been merged yet (and probably should be).

@naturalshine
Copy link
Contributor

The PDF button, on clicking, calls a function [ fromHTMLtoPDF() ] that doesn't exist yet. I suspect this is why it's been removed on the original -- someone didn't get around to writing the functionality. I can add writing a function to do this onto my list if you'd like.

@jmatsushita
Copy link
Member Author

Thanks for the analysis! Maybe we can first replace the PDF button to a link to the corresponding PDF in the pdf folder for now?

@naturalshine
Copy link
Contributor

Ah yes, that's the best solution :) Will do

@jmatsushita jmatsushita changed the title Work out what's going on with the Donwload PDF button. Work out what's going on with the Download PDF button. Dec 3, 2015
@naturalshine
Copy link
Contributor

@jmatsushita This is also fixed, with the button linked to the correct PDF, as we discussed.

@jmatsushita
Copy link
Member Author

Oops... I'm getting something weird when opening in the browser:

image

When opening in Adobe Reader there's further insights about what might be going on:

image

@naturalshine
Copy link
Contributor

Ahh, weird. I think this must have been some glitch; the pdf's are looking fine to me upon regeneration of the site, both from the "download PDF" button, and in the .zip files of the game/ training kit. Of course, upon regeneration of the PDFs with new content, this will need to be checked again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants