Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All tests are pretty flaky #18

Closed
PapaTutuWawa opened this issue Sep 14, 2022 · 3 comments
Closed

All tests are pretty flaky #18

PapaTutuWawa opened this issue Sep 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@PapaTutuWawa
Copy link
Owner

PapaTutuWawa commented Sep 14, 2022

They very occasionally fail for the same reason:

  Instance of 'UnknownSignedPrekeyException'
  package:omemo_dart/src/omemo/sessionmanager.dart 185:7  OmemoSessionManager._addSessionFromKeyExchange
  ===== asynchronous gap ===========================
  package:omemo_dart/src/omemo/sessionmanager.dart 347:7  OmemoSessionManager.decryptMessage
  ===== asynchronous gap ===========================
  test/omemo_test.dart 254:24                             main.<fn>
@PapaTutuWawa PapaTutuWawa added the bug Something isn't working label Sep 14, 2022
@PapaTutuWawa PapaTutuWawa self-assigned this Sep 14, 2022
@PapaTutuWawa
Copy link
Owner Author

PapaTutuWawa commented Sep 14, 2022

bobSpkId: 2763074306
aliceSpkId: 1342758128
kex.spkId: 77, device.spkId: 569114685, device.oldSpkId: 2214281293
00:03 +27 -1: test/omemo_test.dart: Test accepting a session with an old SPK [E]                          
  Instance of 'UnknownSignedPrekeyException'
  package:omemo_dart/src/omemo/sessionmanager.dart 191:7  OmemoSessionManager._addSessionFromKeyExchange
  ===== asynchronous gap ===========================
  package:omemo_dart/src/omemo/sessionmanager.dart 351:7  OmemoSessionManager.decryptMessage
  ===== asynchronous gap ===========================
  test/omemo_test.dart 333:24       

@PapaTutuWawa PapaTutuWawa changed the title Some tests are pretty flaky All tests are pretty flaky Sep 14, 2022
@PapaTutuWawa
Copy link
Owner Author

I think I fixed it. Verified by running

for i in {0..99}; do
	echo "RUN $i"
	dart test -j 8
	[[ ! $? = 0 ]] && exit 1
done

@PapaTutuWawa
Copy link
Owner Author

Hopefully fixed by 438012d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant