Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Alternative Current redstone method #202

Closed
PedroMPagani opened this issue Feb 20, 2024 · 0 comments
Closed

Lack of Alternative Current redstone method #202

PedroMPagani opened this issue Feb 20, 2024 · 0 comments
Labels
type: feature Request for a new Feature.

Comments

@PedroMPagani
Copy link

Is your feature request related to a problem?

Repeaters etc tend to cause a lot of mspt spikes when farms are ticking

Describe the solution you'd like.

Currently I know that the big issue is likely related to how the wire handler is done, which is always looks for states to update, and that would cause crashes.

Describe alternatives you've considered.

Limiting Redstone a lot is an option but you know.. at some point Folia would need to implement this, because it's a very good method :(

Other

I think a good implementation for ths is to attach the wire handlers to the tick region data, every time a region merges or splits, it recalculates all of the nodes and removes nodes that will no longer belong to that region, avoiding then the issue with ticking.
The difference between the vanilla Redstone mechanics and the alternative current is huge in performance.

I did this implementation myself already and it seems to be working good without any crashes, I'll be soon pushing this to DonutSMP prod with safety and logging for crashes, I do not handle the region splitting and merging with keeping the current region's data, I didn't really notice a problem with it yet. I'm just instancing a new wire handler instead.

@PedroMPagani PedroMPagani added status: needs triage type: feature Request for a new Feature. labels Feb 20, 2024
@PedroMPagani PedroMPagani changed the title Lack of Alternative Current Lack of Alternative Current redstone method Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Request for a new Feature.
Projects
None yet
Development

No branches or pull requests

2 participants