Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.4 TODO #10001

Closed
9 of 13 tasks
kennytv opened this issue Dec 5, 2023 · 2 comments
Closed
9 of 13 tasks

1.20.4 TODO #10001

kennytv opened this issue Dec 5, 2023 · 2 comments
Labels
priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon.

Comments

@kennytv
Copy link
Member

kennytv commented Dec 5, 2023

Tasks

@PaperMC PaperMC locked and limited conversation to collaborators Dec 5, 2023
@kennytv kennytv added the priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon. label Dec 5, 2023
@Owen1212055
Copy link
Member

Owen1212055 commented Dec 7, 2023

Screenshot 2023-12-06 at 8 30 41 PM

For this there is alot of other missing disconnect wraps... why are we not wrapping everything in a task runnable? Confused here.

@jpenilla jpenilla changed the title 1.20.3 TODO 1.20.4 TODO Dec 7, 2023
@Machine-Maker
Copy link
Member

For this there is alot of other missing disconnect wraps... why are we not wrapping everything in a task runnable? Confused here.

we actually do have something... or well cb does. Right before the kick event is fired, it checks if its not the primary thread and then moves to the primary thread. But I think this has been around for a while so idk why our fix is needed at all.

@kashike kashike closed this as completed Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon.
Projects
None yet
Development

No branches or pull requests

4 participants