Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockPistonExtendEvent doesn't fire when nothing is pushed #10430

Open
B1ue-Bandit opened this issue Apr 18, 2024 · 2 comments
Open

BlockPistonExtendEvent doesn't fire when nothing is pushed #10430

B1ue-Bandit opened this issue Apr 18, 2024 · 2 comments
Labels
status: needs testing Issue needs verification. type: bug Something doesn't work as it was intended to. version: 1.20.4 Game version 1.20.4

Comments

@B1ue-Bandit
Copy link

Expected behavior

BlockPistonExtendEvent should fire when a piston is activated even if nothing is pushed.

Observed/Actual behavior

The event does not fire when the piston pushes no blocks.

Steps/models to reproduce

Listen for BlockPistonExtendEvent, trigger a piston which is set up to push air & observe nothing even though the piston clearly fires. The event doesn't fire when blocks aren't pushed.

Plugin and Datapack List

No datapacks & no other plugins.

Paper version

Paper version git-Paper-485 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 862299b)

Other

When looking at the paper documentation the described behavior for BlockPistonExtendEvent is "Called when a piston extends" which doesn't seem to be the case if nothing is pushed. BlockPistonRetractEvent has the same issue.

@B1ue-Bandit B1ue-Bandit added status: needs triage type: bug Something doesn't work as it was intended to. labels Apr 18, 2024
@AoElite
Copy link

AoElite commented Apr 18, 2024

Expected behavior would be for getBlocks() to return empty instead of the event not firing at all.

@Machine-Maker
Copy link
Member

It's possible this PR fixes the issue, but I haven't tested that exactly yet. #9258

@Warriorrrr Warriorrrr added status: needs testing Issue needs verification. and removed status: needs triage labels Apr 18, 2024
@kashike kashike added the version: 1.20.4 Game version 1.20.4 label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs testing Issue needs verification. type: bug Something doesn't work as it was intended to. version: 1.20.4 Game version 1.20.4
Projects
Status: No status
Development

No branches or pull requests

5 participants